Changeset 1839

Timestamp:

04/25/07 17:42:26 (6 years ago)

Author:

rob

Message:

2007-04-25 Rob Bradford <rob@…>

• libmokoui/moko-paned-window.c: (moko_paned_window_init), (moko_paned_window_set_ratio): Improve the moko_paned_window_set_ratio function. It's just the ratio of the top half (including menu area and toolbox) to the bottom half. No need to be try and be clever about considering the menu and toolbox because its not clear what the ratio means in that case. Set a default ratio of 1:1.

Location:

trunk/src/target/OM-2007/openmoko-libs

Files:

• ChangeLog (modified) (1 diff)
• libmokoui/moko-paned-window.c (modified) (2 diffs)

trunk/src/target/OM-2007/openmoko-libs/ChangeLog

@@ +1 @@
+2007-04-25  Rob Bradford  <rob@openedhand.com>
+
+        * libmokoui/moko-paned-window.c: (moko_paned_window_init),
+        (moko_paned_window_set_ratio):
+        Improve the moko_paned_window_set_ratio function. It's just the ratio
+        of the top half (including menu area and toolbox) to the bottom half.
+        No need to be try and be clever about considering the menu and toolbox
+        because its not clear what the ratio means in that case.
+        Set a default ratio of 1:1.
+
 2007-04-25  Rob Bradford  <rob@openedhand.com>
 

trunk/src/target/OM-2007/openmoko-libs/libmokoui/moko-paned-window.c

@@ -87 +87 @@
     priv->menubox = NULL;
     priv->toolbox = NULL;
+
+    moko_paned_window_set_ratio (self, 50);
 }
 
@@ -137 +139 @@
     MokoPanedWindowPriv* priv = MOKO_PANED_WINDOW_GET_PRIVATE(self);
     moko_debug( "moko_paned_window_set_ratio" );
-    //FIXME calculate this correctly, need to subtract the height of tool box and menu box
-    //      which is probably not 120 ;-)
-    gtk_paned_set_position( GTK_PANED(priv->outerframe), ratio*(gdk_screen_height()-120)/100 );
+    guint height;
+
+    gtk_window_get_size (GTK_WIDGET (self), NULL, &height);
+
+    gtk_paned_set_position( GTK_PANED(priv->outerframe), ratio * height / 100 );
 }