Changeset 2656

Timestamp:

08/06/07 23:06:12 (6 years ago)

Author:

zecke

Message:

2007-08-06 Holger Hans Peter Freyther <zecke@…>

Implement going forward and backward in the selection view. We have to
remember the FeedSelectionView? in the ApplicationData? to be able to connect the
next/previous signal of FeedItemView?.
Is g_signal_connect_swapped considered evil? And is it normal that the code is different
to get the next/previous item in a GtkListStore??

• src/application-data.h:
• src/feed-selection-view.c: (feed_selection_view_next_item): (feed_selection_view_prev_item):
• src/feed-selection-view.h:
• src/main.c: (create_feed_view): (create_text_view):

Location:

trunk/src/target/OM-2007.2/applications/openmoko-feedreader2

Files:

• ChangeLog (modified) (1 diff)
• src/application-data.h (modified) (2 diffs)
• src/feed-selection-view.c (modified) (1 diff)
• src/feed-selection-view.h (modified) (1 diff)
• src/main.c (modified) (2 diffs)

trunk/src/target/OM-2007.2/applications/openmoko-feedreader2/ChangeLog

@@ +1 @@
+2007-08-06  Holger Hans Peter Freyther  <zecke@selfish.org>
+
+        Implement going forward and backward in the selection view. We have to
+        remember the FeedSelectionView in the ApplicationData to be able to connect the
+        next/previous signal of FeedItemView.
+        Is g_signal_connect_swapped considered evil? And is it normal that the code is different
+        to get the next/previous item in a GtkListStore?
+
+        * src/application-data.h:
+        * src/feed-selection-view.c:
+        (feed_selection_view_next_item):
+        (feed_selection_view_prev_item):
+        * src/feed-selection-view.h:
+        * src/main.c:
+        (create_feed_view):
+        (create_text_view):
+
 2007-08-06  Holger Hans Peter Freyther  <zecke@selfish.org>
 

trunk/src/target/OM-2007.2/applications/openmoko-feedreader2/src/application-data.h

@@ -30 +30 @@
 #include "moko_cache.h"
 #include "feed-item-view.h"
+#include "feed-selection-view.h"
 
 struct ApplicationData {
@@ -36 +37 @@
     GtkNotebook       *notebook;
     FeedItemView      *view;
+    FeedSelectionView *selection_view;
 };
 

trunk/src/target/OM-2007.2/applications/openmoko-feedreader2/src/feed-selection-view.c

@@ -245 +245 @@
 }
 
-
+void
+feed_selection_view_next_item (const FeedSelectionView* view)
+{
+    GtkTreeSelection* selection = gtk_tree_view_get_selection (view->view);
+    GtkTreeIter iter;
+    GtkTreeModel* model;
+    gboolean has_selection = gtk_tree_selection_get_selected (selection, &model, &iter);
+
+    if (has_selection &&  gtk_tree_model_iter_next (model, &iter))
+        gtk_tree_selection_select_iter (selection, &iter);
+}
+
+void
+feed_selection_view_prev_item (const FeedSelectionView* view)
+{
+    GtkTreeSelection* selection = gtk_tree_view_get_selection (view->view);
+    GtkTreeIter iter;
+    GtkTreeModel* model;
+    gboolean has_selection = gtk_tree_selection_get_selected (selection, &model, &iter);
+
+    if (has_selection) {
+        GtkTreePath* path = gtk_tree_model_get_path (model, &iter);
+        if (gtk_tree_path_prev (path))
+            gtk_tree_selection_select_path (selection, path);
+        gtk_tree_path_free (path);
+    }
+}

trunk/src/target/OM-2007.2/applications/openmoko-feedreader2/src/feed-selection-view.h

@@ -68 +68 @@
 gchar*      feed_selection_view_get_search_string       (const FeedSelectionView*);
 
+void        feed_selection_view_next_item               (const FeedSelectionView*);
+void        feed_selection_view_prev_item               (const FeedSelectionView*);
+
 G_END_DECLS
 

trunk/src/target/OM-2007.2/applications/openmoko-feedreader2/src/main.c

@@ -70 +70 @@
 
     g_signal_connect (G_OBJECT(box), "item-changed", G_CALLBACK(feed_selection_changed), data);
+
+    data->selection_view = RSS_FEED_SELECTION_VIEW (box);
 }
 
@@ -81 +83 @@
     gtk_notebook_append_page (data->notebook, GTK_WIDGET(data->view), gtk_image_new_from_stock (GTK_STOCK_MISSING_IMAGE, GTK_ICON_SIZE_LARGE_TOOLBAR));
     gtk_container_child_set (GTK_CONTAINER(data->notebook), GTK_WIDGET(data->view), "tab-expand", TRUE, "tab-fill", TRUE, NULL);
+
+    g_signal_connect_swapped (G_OBJECT (data->view), "next", G_CALLBACK(feed_selection_view_next_item), data->selection_view);
+    g_signal_connect_swapped (G_OBJECT (data->view), "previous", G_CALLBACK(feed_selection_view_prev_item), data->selection_view);
 }