Changeset 3378

Timestamp:

11/08/07 16:11:26 (6 years ago)

Author:

mickey

Message:

libmokogsmd2: fix bogus error check in moko_gsmd_connection_set_antenna_power

Location:

trunk/src/target/OM-2007.2/libraries/libmokogsmd2

Files:

• ChangeLog (modified) (1 diff)
• libmokogsmd/moko-gsmd-connection.c (modified) (1 diff)

trunk/src/target/OM-2007.2/libraries/libmokogsmd2/ChangeLog

@@ +1 @@
+2007-11-08      Michael Lauer   <mickey@openmoko.org>
+
+        * libmokogsmd/moko-gsmd-connection.c: (moko_gsmd_connection_set_antenna_power):
+        Fix error check. The return code of lgsm_phone_power is the return code of
+        socket::send(), hence we better check for != -1.
+
 2007-11-08      Michael Lauer   <mickey@openmoko.org>
 

trunk/src/target/OM-2007.2/libraries/libmokogsmd2/libmokogsmd/moko-gsmd-connection.c

@@ -473 +473 @@
     if (!priv->handle)
     {
-      g_set_error (error, MOKO_GSMD_ERROR, MOKO_GSMD_ERROR_CONNECT, "Error connecting to gsmd");
-      return;
+        g_set_error (error, MOKO_GSMD_ERROR, MOKO_GSMD_ERROR_CONNECT, "Error connecting to gsmd");
+        return;
     }
 
     result = lgsm_phone_power( priv->handle, on ? 1 : 0 );
 
-    if (result != 0)
-    {
-      g_set_error (error, MOKO_GSMD_ERROR, MOKO_GSMD_ERROR_POWER, "Error setting antenna power");
+    if (result == -1)
+    {
+         g_set_error (error, MOKO_GSMD_ERROR, MOKO_GSMD_ERROR_POWER, "Error setting antenna power");
     }
 }