Changeset 3859

Timestamp:

01/17/08 05:34:04 (5 years ago)

Author:

werner

Message:

NAND ECC error correction mis-calculated the bit position, thus turning a
correctable single-bit error into two errors. Fittingly, also reported
uncorrectable errors as success.

The NAND subsystem only does 512 byte reads even on large page NAND, so we can
use hardware ECC also on HXD8 and GTA02. Tests showed that this does indeed
work as expected.

series:

• added fix-hwecc-2410.patch
• commented out s3c2440-nand-disable-hwecc.patch, since this works, even without explicit large page support

fix-hwecc-2410.patch:

• drivers/mtd/nand/s3c2410.c (s3c2410_nand_correct_data): use Pn bits to calculate error position, not Pn'
• drivers/mtd/nand/s3c2410.c (s3c2410_nand_correct_data): don't report uncorrectable errors as "no error"

Location:

branches/src/target/kernel/2.6.24.x/patches

Files:

• fix-hwecc-2410.patch (added)
• series (modified) (2 diffs)

branches/src/target/kernel/2.6.24.x/patches/series

@@ -59 +59 @@
 s3c2410_serial-nodebug.patch
 input-nots-mousedev.patch
-s3c2440-nand-disable-hwecc.patch
+#s3c2440-nand-disable-hwecc.patch
 
 # qt2410 local hacks
@@ -74 +74 @@
 atheros_2_0_sdio_stack.patch
 
+# bad bug
+fix-hwecc-2410.patch
+
 # Preliminary suspend/resume power saving improvements
 suspend-prelim1.patch