Changeset 4562

Timestamp:

07/29/08 16:07:05 (5 years ago)

Author:

tick

Message:

opkg: remove a serious memory leak

when searching every package opkg will clone the package but never released.

File:

• trunk/src/target/opkg/libopkg/opkg.c (modified) (5 diffs)

trunk/src/target/opkg/libopkg/opkg.c

@@ -565 +565 @@
   {
     /* XXX:  Error: Package seems to be not installed (STATUS = NOT_INSTALLED). */
+    opkg_package_free (pdata.package);
     return OPKG_PACKAGE_NOT_INSTALLED;
   }
@@ -640 +641 @@
   if (err)
   {
+
+    opkg_package_free (pdata.package);
     switch (err)
     {
@@ -655 +658 @@
 
   err = opkg_configure_packages (opkg->conf, NULL);
-  if (err)
+  if (err) {
+    opkg_package_free (pdata.package);  
     return OPKG_UNKNOWN_ERROR;
+  }
 
   /* write out status files and file lists */
@@ -907 +912 @@
     package = old_pkg_to_new (pkg);
     callback (opkg, package, user_data);
+    opkg_package_free (package);
   }
 
@@ -951 +957 @@
       package = old_pkg_to_new (new);
       callback (opkg, package, user_data);
+      opkg_package_free (package);
     }
   }