Changeset 4741


Ignore:
Timestamp:
11/02/08 14:05:06 (8 years ago)
Author:
werner
Message:

Yet more cleanup. Avoid the traps that break module unloading.

drivers/ar6000/hif/hif2.c:

  • removed MODULE_LICENSE since it's already in ar6000_drv.c
  • removed MODULE_AUTHOR since I'm only to blame for a tiny fraction of the code in the module :-)
  • HIFShutDownDevice: don't use the trojan "hif" NULL pointer ...
  • sdio_ar6000_remove: avoid death by recursion, don't call deviceRemovedHandler
Location:
developers/werner/wlan-spi/patches-tracking
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • developers/werner/wlan-spi/patches-tracking/gta02-mmc-mci.patch

    r4738 r4741  
    33Index: ktrack/arch/arm/mach-s3c2440/Kconfig 
    44=================================================================== 
    5 --- ktrack.orig/arch/arm/mach-s3c2440/Kconfig   2008-11-02 07:32:56.000000000 -0200 
    6 +++ ktrack/arch/arm/mach-s3c2440/Kconfig        2008-11-02 07:32:56.000000000 -0200 
     5--- ktrack.orig/arch/arm/mach-s3c2440/Kconfig   2008-11-02 11:04:06.000000000 -0200 
     6+++ ktrack/arch/arm/mach-s3c2440/Kconfig        2008-11-02 11:04:06.000000000 -0200 
    77@@ -113,6 +113,11 @@ 
    88                 bool "GPIO bit-banging SPI" 
     
    1919Index: ktrack/arch/arm/mach-s3c2440/mach-gta02.c 
    2020=================================================================== 
    21 --- ktrack.orig/arch/arm/mach-s3c2440/mach-gta02.c      2008-11-02 07:32:56.000000000 -0200 
    22 +++ ktrack/arch/arm/mach-s3c2440/mach-gta02.c   2008-11-02 07:32:56.000000000 -0200 
     21--- ktrack.orig/arch/arm/mach-s3c2440/mach-gta02.c      2008-11-02 11:04:06.000000000 -0200 
     22+++ ktrack/arch/arm/mach-s3c2440/mach-gta02.c   2008-11-02 11:04:06.000000000 -0200 
    2323@@ -1720,6 +1720,11 @@ 
    2424        platform_device_register(&gta02_spi_wlan); 
  • developers/werner/wlan-spi/patches-tracking/hif-linux-sdio.patch

    r4740 r4741  
    2626=================================================================== 
    2727--- /dev/null   1970-01-01 00:00:00.000000000 +0000 
    28 +++ ktrack/drivers/ar6000/hif/hif2.c    2008-11-02 11:01:12.000000000 -0200 
    29 @@ -0,0 +1,592 @@ 
     28+++ ktrack/drivers/ar6000/hif/hif2.c    2008-11-02 12:01:30.000000000 -0200 
     29@@ -0,0 +1,593 @@ 
    3030+/* 
    3131+ * hif2.c - HIF layer re-implementation for the Linux SDIO stack 
     
    546546+       int ret; 
    547547+ 
     548+#if 0 
     549+       /* 
     550+        * Funny, Atheros' HIF does this call, but this just puts us in a 
     551+        * recursion through HTCShutDown/HIFShutDown if unloading the 
     552+        * module. 
     553+        */ 
    548554+       ret = htcCallbacks.deviceRemovedHandler(hif->htc_handle, A_OK); 
    549555+       if (ret != A_OK) 
    550556+               dev_err(dev, "deviceRemovedHandler: %d\n", ret); 
     557+#endif 
    551558+       wait_queue_empty(hif); 
    552559+       ret = kthread_stop(hif->io_task); 
     
    611618+void HIFShutDownDevice(HIF_DEVICE *hif) 
    612619+{ 
    613 +       struct device *dev = HIFGetOSDevice(hif); 
    614 + 
    615 +       dev_dbg(dev, "HIFShutDownDevice\n"); 
     620+       /* Beware, HTCShutDown calls us with hif == NULL ! */ 
    616621+       sdio_unregister_driver(&sdio_ar6000_driver); 
    617622+} 
    618 + 
    619 + 
    620 +MODULE_AUTHOR("Werner Almesberger"); 
    621 +MODULE_LICENSE("GPL v2"); 
  • developers/werner/wlan-spi/patches-tracking/series

    r4740 r4741  
    3333# still needs a bit more love ... 
    3434#s3c-mmc-sdio-int.patch 
    35 #ecc 
Note: See TracChangeset for help on using the changeset viewer.