Changeset 4958

Timestamp:

03/11/09 11:45:59 (4 years ago)

Author:

werner

Message:

Bring it to state as posted.

Location:

developers/werner/gta03/cam/patches

Files:

• NOTES (modified) (2 diffs)
• series (modified) (1 diff)
• use-camera-clock.patch (modified) (1 diff)

developers/werner/gta03/cam/patches/NOTES

@@ -4 +4 @@
   --from 'Werner Almesberger <werner@openmoko.org>' \
   --sender werner@openmoko.org \
-  --subject 'Camera driver cleanup' \
-  --to openmoko-kernel@lists.openmoko.org
-
-quilt mail --mbox bar --prefix PATCH \
-  --from 'Werner Almesberger <werner@openmoko.org>' \
-  --sender werner@openmoko.org \
-  --subject 'Camera clock fixes' \
+  --subject 'Define and enable camera interface clock' \
   --to openmoko-kernel@lists.openmoko.org
 
@@ -18 +12 @@
 -----
 
-Camera driver cleanup
+This patch series corrects the name of the camera clock, adds the
+camera clock, and explicitly enables it.
 
-This patch series does some light cleanup on the camera driver.
-Most of the warnings, #ifdef hell, larger-scale redundancy, and
-other gremlins are still there.
+We need to do this since Qi turns off many of the clocks it doesn't
+use after commit a24b5fcf84d2cf633a3f660edd23fa4c2a3da231
+
+Ben, patches 1/3 and 2/3 are generic and should be of interest for
+you.
+
+Andy, this patch series is based on the patch that moves power
+control to he driver. It's not in git yet, so please don't forget
+to apply it first.
+
+This patch series is only partially tested since that clock gating
+change also broke the LCM driver. (Matt is working on it.)
 
 - Werner
-
------
-
-Camera clock fixes
-
-This patch series should (finally) get the camera clock right.
-
-Ben, patches 2/4 and 3/4 fix more issues in
-arch/arm/plat-s3c64xx/s3c6400-clock.c
-
-Andy, patch 1/4 is a reissue. It seems that you got one of my
-botched mails when applying the first one and the commit is
-thus empty.
-
-- Werner

developers/werner/gta03/cam/patches/series

@@ -1 +1 @@
 #hack-s3c_device_usb.patch
+#defer-camera-powerup.patch
+
 rename-camera-clock.patch
 add-real-camif-clock.patch
-defer-camera-powerup.patch
 use-camera-clock.patch

developers/werner/gta03/cam/patches/use-camera-clock.patch

@@ -1 @@
-Index: cam/drivers/media/video/s3c_camera_driver.c
+Enable camera interface clock
+
+This patch explicitly enabled to "camif" clock, to make the driver
+work again with Qi commit a24b5fcf84d2cf633a3f660edd23fa4c2a3da231.
+
+Note that this is not fully tested since the Qi change also broke
+the LCM driver.
+
+Signed-off-by: Werner Almesberger <werner@openmoko.org>
+
+---
+
+ifIndex: cam/drivers/media/video/s3c_camera_driver.c
 ===================================================================
 --- cam.orig/drivers/media/video/s3c_camera_driver.c    2009-03-11 16:58:55.000000000 +0800