Ticket #1004 (closed defect: fixed)

Opened 11 years ago

Last modified 11 years ago

Dialer keypad is leaking memory on normal presses

Reported by: exabyte@… Owned by: thomas@…
Priority: high Milestone:
Component: openmoko-dialer Version: 2007.2
Severity: normal Keywords:
Cc: buglog@… Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: PatchReviewResult:
Reproducible:

Description

When the buttons a pressed, time data is allocated. Unless the button is holded
and the moko_dialer_panel_hold_timeout frees the allocated memory, it remains
allocated and unreferenced.

Attachments

mokodialer_leak_fix.diff (854 bytes) - added by exabyte@… 11 years ago.
Automatically free the allocated data structure when the timeout source is destroyed

Change History

Changed 11 years ago by exabyte@…

Automatically free the allocated data structure when the timeout source is destroyed

comment:1 Changed 11 years ago by thomas@…

  • Status changed from new to closed
  • Resolution set to fixed

Committed to SVN. Thanks.

comment:2 Changed 11 years ago by thomas@…

  • Status changed from closed to reopened
  • Resolution fixed deleted

Actually, the data->value also needs to be freed, so we will have to add a
custom function to free all the data.

comment:3 Changed 11 years ago by thomas@…

  • Status changed from reopened to closed
  • Resolution set to fixed

Sorry, I think I was confused by some valgrind output. Your patch was fine as
before.

Note: See TracTickets for help on using tickets.