Ticket #1082 (closed defect: fixed)

Opened 11 years ago

Last modified 11 years ago

PIN Status Missing

Reported by: thomas@… Owned by: erin_yueh@…
Priority: high Milestone:
Component: gsmd Version: current svn head
Severity: normal Keywords:
Cc: buglog@…, balrogg@…, tick@…, sean_chiang@… Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: PatchReviewResult:
Reproducible:

Description

PIN status functions (AT+CPIN?) are not implemented in gsmd

Attachments

get_PIN_status.patch (2.8 KB) - added by erin_yueh@… 11 years ago.
get PIN status
secondtryCPIN.patch (8.3 KB) - added by erin_yueh@… 11 years ago.
2nd try CPIN status
getCPIN.patch (3.9 KB) - added by erin_yueh@… 11 years ago.
move PIN name and change this first item name

Change History

comment:1 Changed 11 years ago by balrogg@…

  • Cc balrogg@… added

comment:2 Changed 11 years ago by tick@…

  • Owner changed from laforge@… to erin_yueh@…

comment:3 Changed 11 years ago by tick@…

  • Cc tick@… added

comment:4 Changed 11 years ago by tick@…

  • Cc sean_chiang@… added

comment:5 Changed 11 years ago by erin_yueh@…

  • Status changed from new to assigned

Changed 11 years ago by erin_yueh@…

get PIN status

comment:6 Changed 11 years ago by erin_yueh@…

  • Status changed from assigned to closed
  • Resolution set to fixed

committed the patch

comment:7 Changed 11 years ago by balrogg@…

How about putting all the code in "PIN" instead of "PHONE"? (pin.c instead of
misc.c, etc.) This function is strictly connected with PIN functionality.

Also reporting the full modem response to the client is not very useful, the
client could equally well just use the passthrough mode. I think gsmd should go
through all the reported pin names and return some kind of mask with one bit
set/cleared for each pin type.

comment:8 Changed 11 years ago by erin_yueh@…

Yeah, i agree with u. i will put "PIN" functions to related code. Also, parse
the response and use "enum gsmd_pin_type". Thanks!

Changed 11 years ago by erin_yueh@…

2nd try CPIN status

Changed 11 years ago by erin_yueh@…

move PIN name and change this first item name

comment:9 Changed 11 years ago by balrogg@…

Thanks!

Note: See TracTickets for help on using tickets.