Ticket #1160 (closed defect: invalid)
SMS messages are sorted by date in ascending order.
| Reported by: | roman.moravcik@… | Owned by: | chris@… |
|---|---|---|---|
| Priority: | high | Milestone: | |
| Component: | openmoko-messages | Version: | current svn head |
| Severity: | normal | Keywords: | |
| Cc: | buglog@… | Blocked By: | |
| Blocking: | Estimated Completion (week): | ||
| HasPatchForReview: | PatchReviewResult: | ||
| Reproducible: |
Description
openmoko-messages application sort sms messages by date
in ascending order, but I think the messages should
sorted in descending order. If you receive a new sms
message you must scroll down to read it and this isn't
most practical.
Attachments
Change History
Changed 5 years ago by roman.moravcik@…
- Attachment jana_note_sort_descending.patch added
Changed 5 years ago by roman.moravcik@…
- Attachment messages_sort_descending.patch added
[PATCH] Sort SMS messages in descending order
comment:2 Changed 5 years ago by chris@…
- Status changed from new to closed
- Resolution set to invalid
I appreciate the effort put into the patch here, but I don't agree with the
approach. A better solution is to just programmatically scroll the list to the
bottom - At least in the default C locale, text is read top-to-bottom -
reversing this just for convenience of reading new messages probably isn't a
good idea.
Also, JanaGtkNoteStore? is just an extension of a list store, there's no need to
add a whole new function to reverse the sort order when you can just use simple
GTK functions to do so.
I've added code to scroll the list to the bottom in r3780, so this should no
longer be an issue.
[PATCH] Jana gtk note store sort in descending order