Ticket #1168 (closed defect: fixed)
eliminate GCC warning for gsmd
| Reported by: | erin_yueh@… | Owned by: | erin_yueh@… |
|---|---|---|---|
| Priority: | high | Milestone: | |
| Component: | gsmd | Version: | 2007.2 |
| Severity: | normal | Keywords: | |
| Cc: | buglog@…, werner@… | Blocked By: | |
| Blocking: | Estimated Completion (week): | ||
| HasPatchForReview: | PatchReviewResult: | ||
| Reproducible: |
Description
copied from the mailing list
=======================
Hello list,
I just attempt to eliminate GCC warnings resulting from "-Wall
- -std=gnu99" cflags.
Most changes are trivial including fixes against typo and removing
unused codes. Also, this changes prototypes for parser-oriented
functions with const modifier. Please refer to the attachment for details.
Thanks,
- -jserv
Attachments
Change History
Changed 5 years ago by erin_yueh@…
- Attachment eliminate_gcc_warning.patch added
eliminate gcc warning
comment:2 Changed 5 years ago by erin_yueh@…
- Summary changed from eliminate GCC warning to eliminate GCC warning for gsmd
comment:3 Changed 5 years ago by erin_yueh@…
- Status changed from assigned to closed
- Resolution set to fixed
patch committed
comment:4 Changed 5 years ago by werner@…
- Cc werner@… added
By the way, as a general remark, I find the following options useful
for makeing gcc find my areas of sloppiness:
-Wall -Wshadow -Werror -Wstrict-prototypes -Wmissing-prototypes
-Wmissing-declarations
Particularly -Werror may be a bit ambitious for production code (sometimes,
some header files produce an unexpected warning on some obscure platform),
but it can be quite useful for occasional checking.
