Ticket #1182 (closed defect: fixed)

Opened 11 years ago

Last modified 11 years ago

Charging current measurement is incorrect (fix)

Reported by: andrew.paulsen@… Owned by: willie_chen@…
Priority: high Milestone:
Component: kernel Version: 2007.2
Severity: normal Keywords:
Cc: buglog@… Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: PatchReviewResult:
Reproducible:

Description

There are multiple problems with the charging current measurement that I have
fixed in this patch.

  • Least significant bits of ADCIN1 were not shifted correctly
  • A 6V reference voltage was assumed, but a 2.4V reference is actually used
  • Math could result in negative values, but unsigned types were used
  • Explicit type casting was added to the calculation to correct a possible overflow

Attachments

gta01-charge-current.patch (1.5 KB) - added by andrew.paulsen@… 11 years ago.
Fixes charge current measurement. Applies after the patch in bug 1181.

Change History

Changed 11 years ago by andrew.paulsen@…

Fixes charge current measurement. Applies after the patch in bug 1181.

comment:1 Changed 11 years ago by werner@…

Patch applied in SVN revision 4041. (With minor editing.)

comment:2 Changed 11 years ago by andy

  • Status changed from new to closed
  • Resolution set to fixed

Was applied.

Note: See TracTickets for help on using tickets.