Ticket #121 (closed defect: fixed)

Opened 12 years ago

Last modified 12 years ago

merge openmoko-mainmenu into openmoko-mainmenu (panel)

Reported by: mickey@… Owned by: mickey@…
Priority: normal Milestone:
Component: Applications & Dependencies Version: unspecified
Severity: critical Keywords:
Cc: buglog@… Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: PatchReviewResult:
Reproducible:

Description

mainmenu needs to be displayed very quickly, so integrate it into the
openmoko-mainmenu panel app, don't exec from there.

Change History

comment:1 Changed 12 years ago by laforge@…

  • Severity changed from normal to critical

comment:2 Changed 12 years ago by laforge@…

  • Priority changed from high to normal

comment:3 Changed 12 years ago by sunzhiyong@…

  • Status changed from new to assigned

How to merge openmoko-mainmenu into openmoko-panel-mainmenu?
Now there are two menus in openmoko-mainmenu stylus and finger, and both of them
apply the show and hide functions.

comment:4 Changed 12 years ago by mickey@…

Can you show me screenshots of both? I don't know where the difference is
between a finger-style main menu and a stylus-style main menu.

To mainmenu into panel-mainmenu you just have to move the source into the
panel-mainmenu tree and connect the button callbacks from panel-mainmenu to
functions that show/hide the mainmenu widget.

comment:5 Changed 12 years ago by sunzhiyong@…

finger-style main menu is now what you see when you run openmoko-mainmenu, it is
base on mokoiconview.
stylus-style main menu is popup menu, which is based on gtkmenu.
you can find them here:
https://wiki.internal.openmoko.org/wiki/Image:Finger-menu.png
https://wiki.internal.openmoko.org/wiki/Image:Stylus-menu.png

The action of these two menu is when
Tapping on mainmenu-plugin pop stylus menu.
Tap on hold mainmenu-plugin pop finger menu.

comment:6 Changed 12 years ago by mickey@…

thanks, i understand the difference now, however how is the finger main menu
then to be opened? tap-with-hold on the main menu applet?

comment:7 Changed 12 years ago by sunzhiyong@…

Now stylus style mainmenu has been add into the openmoko-panel-mainmenu(please
check),

About the actions of openmoko-mainmenu (panel):
Openmoko-panel-mainmenu actions(what is listed on the wiki):

  • "tap main menu panel plug-in" popup stylus style main menu;
  • "tap hold main menu panel plug-in" show desktop;
  • "press Auxilary key" show moko finger style main menu;

Those above are the actions of main menu and its plug-in, where we are specified
on wiki, however I don't think it is good enough.

Reasons:

  1. we have had a panel plug-in show desktop now, it is useless to do this here

again.

  1. "tap" and "tap hold" show different style of menu will be easy to understand

or accessible for users.

So in my opinion, I think this order would be more reasonable:

  • "tap " show stylus style main menu;
  • "tap hold" show finger style main menu;
  • "press Auxilary key" show finger style main menu (if it is necessary, or use

to do some other function)

  • put show desk top function to other plug-in. or footer.

what do you think?

comment:8 Changed 12 years ago by stefan@…

  • dependson set to 128

openmoko-mainmenu is now merged into the panel applet. Just tap'n'hold is
pending clarification from #128

comment:9 Changed 12 years ago by elrond+bugzilla.openmoko.org@…

So #128 has been clarified, it seems, what's up with this bug?

comment:10 Changed 12 years ago by stefan@…

  • Status changed from assigned to closed
  • Resolution set to fixed

Finished in r2363

comment:11 Changed 12 years ago by elrond+bugzilla.openmoko.org@…

  • blocked set to 126
Note: See TracTickets for help on using tickets.