Ticket #1255 (assigned enhancement)

Opened 10 years ago

Last modified 8 years ago

No indication of battery charging when power is off

Reported by: will@… Owned by: andy@…
Priority: highest Milestone: Om2008.8
Component: kernel Version: GTA02v6
Severity: normal Keywords: Om2009
Cc: buglog@…, openmoko-kernel@…, testing@… Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: no PatchReviewResult:
Reproducible:

Description

There is no way to tell if the battery is charging when the AC charger is plugged and the device is OFF.
Generally there is a flashing LED light to let users know something is charging.

Change History

comment:1 follow-up: ↓ 2 Changed 10 years ago by tony@…

  • Status changed from new to assigned

Matt/Andy/Werner? working on u-boot level charging logic

comment:2 in reply to: ↑ 1 Changed 10 years ago by regina_kim

  • Owner changed from tony@… to andy@…
  • Cc regina_kim@… added
  • Version changed from unspecified to GTA02v6
  • Component changed from Applications & Dependencies to System Software
  • Type changed from defect to enhancement

Replying to tony@openmoko.com:

Matt/Andy/Werner? working on u-boot level charging logic

comment:3 Changed 10 years ago by regina_kim

  • Milestone set to ASU

comment:4 Changed 10 years ago by will

  • Cc will@… added

comment:5 follow-up: ↓ 9 Changed 10 years ago by andy

After discussion with Holger and Carsten, we decided to attack this by simply booting the device normally if power inserted while off. Standard charging indication can deal with this request then (when that is done).

comment:6 Changed 10 years ago by mrintegrity

  • Type changed from enhancement to defect

I really find the phone switching it's self on when plugging in/out very annoying, particularly when I'm at work and have it off but generally plug it into my pc to charge.

BTW,

Just got my freerunner today, great stuff :)

comment:7 Changed 10 years ago by mrintegrity

  • Type changed from defect to enhancement

comment:8 Changed 10 years ago by roh

  • Owner changed from andy@… to andy

comment:9 in reply to: ↑ 5 Changed 10 years ago by will

  • Status changed from assigned to in_testing
  • Keywords must have added

Replying to andy:

After discussion with Holger and Carsten, we decided to attack this by simply booting the device normally if power inserted while off. Standard charging indication can deal with this request then (when that is done).

Moving to Testing.
This should already work, seen it a million times already.

comment:10 Changed 10 years ago by regina_kim

kernel : 200807017-asu.stable-uImage.bin
rootfs : 200807017-asu.stable-rootfs.jffs2

above with that image not fixed yet.

nothing happen even no red light when AC charger is plugged and the device is OFF.

will try to test again with Monday's image

comment:11 Changed 10 years ago by regina_kim

  • Owner changed from andy to andy@…
  • Status changed from in_testing to assigned

comment:12 follow-up: ↓ 13 Changed 10 years ago by andy

There are two related things going on here.

Red light when charging #1482 has been ready to roll from our side for a while, I saw Julian Chu has taken on setting the charging trigger in userspace, which should solve it and let us close that.

For this issue, we decided that power ON by USB charger insertion was the best solution. Then #1482 solution will also solve this one, because we will be ON normally during charging.

The last part we didn't solve AFAIK is charging indication during suspend. But we have plans for timed wake from suspend and we can imagine to do it eventually.

comment:13 in reply to: ↑ 12 Changed 10 years ago by will

Replying to andy:

The last part we didn't solve AFAIK is charging indication during suspend. But we have plans for timed wake from suspend and we can imagine to do it eventually.

Ok, so the red light will turn off once suspend is activated, even if it was on before activation, correct?

comment:14 Changed 10 years ago by andy

Yes suspend forces all the LEDs off currently and they'll get set again on wake.

comment:15 Changed 10 years ago by wendy_hung

  • Keywords have, Om2008.11 added; have removed
  • HasPatchForReview unset

comment:16 follow-up: ↓ 18 Changed 9 years ago by marek

  • Keywords Om2009 added; must have, Om2008.11 removed
  • Cc testing@… added; regina_kim@…, will@… removed

Test case: plug in charger when device is off / suspended -> led should do something
Will: do we want that ?

comment:17 Changed 9 years ago by andy

Practically from USB insertion from suspend the LED should do something after a "little while" and from OFF, the LED will do something "partway through boot".

comment:18 in reply to: ↑ 16 Changed 9 years ago by will

Replying to marek:

Test case: plug in charger when device is off / suspended -> led should do something
Will: do we want that ?

The original idea was LED should stay lit as long as the device is charging (over USB or power charger). Once charging is complete, LED can turn off.

comment:19 Changed 8 years ago by joerg

Kernel must not disable LEDs during suspend.
The actual management of charge indication LED is a task to be handled in userland, I'd guess FSO has the means to do that.
So please any of the kernel devels check the LEDs can be kept at 100% at least, during suspend - then close this ticket.

Note: See TracTickets for help on using tickets.