Ticket #1288 (closed defect: fixed)

Opened 11 years ago

Last modified 11 years ago

No power option for Wifi in power menu

Reported by: will@… Owned by: erin_yueh@…
Priority: highest Milestone:
Component: Applications & Dependencies Version: unspecified
Severity: normal Keywords:
Cc: buglog@…, rob@…, john_lee@…, tony@…, allen_lin@…, sameo@… Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: PatchReviewResult:
Reproducible:

Description

We need a Wifi option that powers on/off Wifi

Attachments

ar6k-radio_switch.patch (5.6 KB) - added by sameo@… 11 years ago.
Radio switch patch for ar6k

Change History

comment:1 Changed 11 years ago by erin_yueh@…

  • Owner changed from erin_yueh@… to thomas@…

comment:2 Changed 11 years ago by erin_yueh@…

  • Priority changed from high to highest

comment:3 Changed 11 years ago by thomas@…

  • Cc rob@…, sameo@… added

It seems the power option is unsupported by the driver:

root@fic-gta02:~# iwconfig eth0 txpower off
Error for wireless request "Set Tx Power" (8B26) :

SET failed on device eth0 ; Operation not supported.

comment:4 Changed 11 years ago by sameo@…

No, txpower is not implemented.
I assume we really want to turn radio off here, right ?

From the Atheros header files, I don't see any easy way to switch the radio.
We'd need to power the whole chip down for that, and then go through the whole
SDIO init process whenever we want to turn radio on.
Before going further, I sent an email to the Atheros engineers and check from them
if there is some sort of RF switch command.
I'll give an update once I get an answer from them.

Changed 11 years ago by sameo@…

Radio switch patch for ar6k

comment:5 Changed 11 years ago by thomas@…

  • Cc tony@… added

I'm not sure I'm the correct person to test this (I wouldn't know where to
start). Wolfgang suggests Tony would be able to try the patch and verify it works.

comment:6 Changed 11 years ago by will@…

  • Cc allen_lin@… added

Allen or Erin can help verify.
Guys, can you take a look please?
Wifi Icon is coming, I haven't had time last week.
Sorry about that.

comment:7 Changed 11 years ago by rob@…

Teeny error in this patch (confirmed by Samuel, thanks!):

+ if (ar->arRadioSwitch == WLAN_DISABLED) {
+ rrq->disabled = 0;
+ return 0;
+ }

disabled should be set to 1 not 0.

comment:8 Changed 11 years ago by will@…

asked the original designer to re-draw the icon.
should arrive early next week.

comment:9 Changed 11 years ago by rob@…

  • Cc john_lee@… added

Right.

I've just added code to the power menu in neod to add an appropriate menu item.

I noticed that none of the other device power menu items were hooked up
(GSM/Bluetooth/GPS) so I did that too.

This change went in with r4324.

Please update the recipe for neod and test.

comment:10 Changed 11 years ago by thomas@…

  • Owner changed from thomas@… to erin_yueh@…

I think this is fixed now. Could someone please verify?

comment:11 Changed 11 years ago by john_lee@…

  • Status changed from new to closed
  • Resolution set to fixed

yeah it's there.

comment:12 Changed 11 years ago by erin_yueh@…

  • Keywords VERIFIED added

verified it by 0417 freerunner image

comment:13 Changed 11 years ago by erin_yueh@…

  • Keywords VERIFIED removed

it's fixed and verified. then close it!

Note: See TracTickets for help on using tickets.