Ticket #1307 (closed defect: fixed)

Opened 11 years ago

Last modified 11 years ago

Add to Contacts from unknow folder

Reported by: erin_yueh@… Owned by: thomas@…
Priority: high Milestone:
Component: openmoko-messages Version: 2007.2
Severity: normal Keywords: VERIFIED
Cc: buglog@…, will@… Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: PatchReviewResult:
Reproducible:

Description

  1. launch Messaging application
  2. choose unknon sender
  3. choose any one message
  4. can add the number to Contacts

Change History

comment:1 Changed 11 years ago by thomas@…

  • Summary changed from Add to Contacts from unknow folder to Add to Contacts from unknow folder

Which toolbar do you expect to see this button? There are already four items in
the message list toolbar, which is the maximum number of items.

comment:2 Changed 11 years ago by erin_yueh@…

  • Cc will@… added

comment:3 Changed 11 years ago by thomas@…

  • Status changed from new to closed
  • Resolution set to fixed

Feature implemented in r4298.

comment:4 Changed 11 years ago by erin_yueh@…

  • Status changed from closed to reopened
  • Resolution fixed deleted

follow these steps, then we can create a Contact. eg. 'Test'

  1. launch Contacts application
  2. find a contact, the name is 'Test', but the number field is empty

comment:5 Changed 11 years ago by thomas@…

I just committed some fixes and it all seems to work fine for me. Can you check
with the latest version (r4304)?

comment:6 Changed 11 years ago by erin_yueh@…

i guess i know the problem why i cannot see the number in Contacts. There is no
subscriber number from the network in Taiwan. Therefore, when i send a SMS out,
there is no sender number in this SMS.

comment:7 Changed 11 years ago by thomas@…

Perhaps I should add a warning if no author number was found on the SMS?

comment:8 Changed 11 years ago by erin_yueh@…

yeah! that would be great and make more sense...

comment:9 Changed 11 years ago by thomas@…

After further thought, I think openmoko-messages should probably check to see if
SMS was sent or received. If the SMS was sent, then add recipient number. If the
SMS was received, then add author number.

Does this sound acceptable?

comment:10 Changed 11 years ago by erin_yueh@…

yeah! it makes sense.

comment:11 Changed 11 years ago by thomas@…

Ok, added in r4320. Please test and close this bug if all fixed.

comment:12 Changed 11 years ago by erin_yueh@…

  • Status changed from reopened to closed
  • Resolution set to fixed

verified it with openmoko-messages2 - 0.1.0+svnr4320-r0 -, bug fixed.

comment:13 Changed 11 years ago by erin_yueh@…

  • Keywords VERIFIED added
Note: See TracTickets for help on using tickets.