Ticket #1606 (new enhancement)

Opened 10 years ago

Last modified 10 years ago

Match numbers to contacts more fuzzy

Reported by: nomeata Owned by: openmoko-devel
Priority: normal Milestone:
Component: unknown Version: 2007.2
Severity: normal Keywords: patch
Cc: Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: yes PatchReviewResult:
Reproducible:

Description

Hi,

in my (imported) contact list, I have “human readable” numbers such as “07032/12345” or “0049 170 12345”. But openmoko (at least the messaging part) only finds contacts that have the “official” version of the number (++4917012345).

It would be better if it could match numbers to names a bit more fuzzily. I have hacked some support for that to openmoko-messages2, but this should probably solved somewhere more central. Anyways, this should give some hints, and can be used by people who want this behaviour. The patch (against SVN rev 4522) is attached.

Thanks,
Joachim

Attachments

gen-before.sh (134 bytes) - added by nomeata 10 years ago.
Example implementation, openmoko-messages only
openmoko-messages-number-normalize.patch (3.9 KB) - added by nomeata 10 years ago.
New version, also replaces numbers by names using the same number normalization
openmoko-messages-number-normalize.2.patch (5.7 KB) - added by nomeata 10 years ago.
New version, now complete WRT openmoko-messages

Change History

Changed 10 years ago by nomeata

Example implementation, openmoko-messages only

comment:1 Changed 10 years ago by nomeata

Actually, the offical form for a number has only one + (+4917012345)

Changed 10 years ago by nomeata

New version, also replaces numbers by names using the same number normalization

Changed 10 years ago by nomeata

New version, now complete WRT openmoko-messages

comment:2 Changed 10 years ago by nomeata

Hi,

I think I now normalized the phone number everywhere in openmoko-messages2 with the latest patch. But unfortunately, the matching for the notes view is done by libjana, which passes it off to evolution-data-server (e_cal_get_query), which probably only supports string comparisons.

Where do we go from here?

comment:3 Changed 10 years ago by nomeata

  • Keywords patch added

Hi,

more up-to-date patches are at
http://lists.openmoko.org/pipermail/devel/2008-July/000131.html

These seem to be complete.

Greetings,
Joachim

comment:4 Changed 10 years ago by roh

  • HasPatchForReview set

BatchModify?: set HasPatchForReview? on 'keyword' contains 'patch'

Note: See TracTickets for help on using tickets.