Ticket #1610 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

it can save as same name(duplicate), same number and same group name as well.

Reported by: regina_kim Owned by: charlie
Priority: high Milestone: Om2008.9
Component: Qtopia Version:
Severity: major Keywords: Om2008.11
Cc: testing@… Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: no PatchReviewResult:
Reproducible:

Description

kernel : 20080705-asu.stable-uImage.bin
rootfs : 200807014-asu.stable-rootfs.jffs2

summary : it can save as same name(duplicate), same number and same group name as well.

step :

  1. go to contact and try to save contact as same name which already saved in contacts

current result : it can save

expected result : it should be show alert message "the number or name already exist and do you want replace ?"

Change History

comment:1 Changed 10 years ago by will

  • Priority changed from normal to low

well.. this is a behaviour issue.
my phone can save an infinite number of contacts with the same name.

comment:2 Changed 10 years ago by roh

  • Owner changed from zecke@… to zecke

comment:3 Changed 10 years ago by wendy_hung

  • Priority changed from low to high
  • Type changed from enhancement to defect
  • Severity changed from normal to major

comment:4 follow-up: ↓ 5 Changed 10 years ago by wendy_hung

Tested with the image below:

kernel:20080807-asu.stable-uImage.bin
root file system:20080807-asu.stable-rootfs.jffs2

Still in the case, I think at lease it should show up alert message.

comment:5 in reply to: ↑ 4 Changed 10 years ago by wendy_hung

Replying to wendy_hung:

Tested with the image below:

kernel:20080807-asu.stable-uImage.bin
root file system:20080807-asu.stable-rootfs.jffs2

Still in the case, I think at lease it should show up alert message.

at least, sorry

comment:6 Changed 10 years ago by charlie

  • Status changed from new to in_testing

This problem should be solves in Qtopia commit 1d13b889cbeedb074feffda235e7876f61e6a5e5.

I added a Warning message : "A contact with the same name is already present : Continue / Cancel"

When we choose cancel we return to the contact editor, where we can change the name.

comment:7 Changed 10 years ago by zecke

  • Milestone changed from Om2008.8 to Om2008.9

Maybe there is a faster (than linear searching way) to find a duplicate name. Besides that I'm fine with the approach and implementation (mostly). Thanks.

comment:8 Changed 10 years ago by wendy_hung

  • Owner changed from zecke to charlie
  • Status changed from in_testing to assigned

Hi Charlie,
thanks for your help, i saw the warning message in adding same contact name, but when adding same group name doesn't have warning message. Could you also help us to put the Waring message in adding same group name?

TEST WITH THE IMAGE BELOW:
kernel:Om2008.8-gta02-20080903.uImage.bin
root file system:Om2008.8-gta02-20080904.rootfs.jffs2

comment:9 Changed 10 years ago by wendy_hung

SORRY the image was wrong, should be:
kernel:Om2008.8-gta02-20080903.uImage.bin
root file system:Om2008.8-gta02-20080908.rootfs.jffs2

comment:10 Changed 10 years ago by charlie

  • Status changed from assigned to accepted

I just added a warning message for the case when we add a group already presents.

There is still no check for "same number" though.

comment:11 Changed 10 years ago by john_lee

  • HasPatchForReview unset

if it's done, shall we put this into testing?

comment:12 Changed 10 years ago by wendy_hung

  • Keywords Om2008.11 added

comment:13 Changed 10 years ago by john_lee

updated sane-srcrev.inc in om.dev. Charlie, is it okay to put this in testing now? If yes, please set to testing.

comment:14 Changed 10 years ago by wendy_hung

  • Status changed from accepted to in_testing

comment:15 Changed 10 years ago by sushama

  • Status changed from in_testing to closed
  • Resolution set to fixed

update date:28-nov-2008
Test date:28-nov-2008
When a new group with same name is added a warning message is displayed.
works as expected now . closed

Note: See TracTickets for help on using tickets.