Ticket #1623 (closed enhancement: fixed)
Suspend on power button: first turn off screen, then suspend
| Reported by: | will | Owned by: | andy |
|---|---|---|---|
| Priority: | high | Milestone: | Om2008.8 |
| Component: | kernel | Version: | |
| Severity: | major | Keywords: | must have |
| Cc: | raster@… | Blocked By: | |
| Blocking: | Estimated Completion (week): | ||
| HasPatchForReview: | PatchReviewResult: | ||
| Reproducible: |
Description
We want to hide the suspend noise on the screen via turning OFF the screen first.
And vice versa when coming up, turn on screen last.
Change History
comment:2 Changed 5 years ago by will
Will try this out.
The auto suspend in ASU is currently set to activate 1 sec after the screen goes to sleep.
The question here is, by pressing the power switch, can we put the screen to sleep, which then activates suspend one second later? Then pressing power a second time would then wake up the system, along with the screen.
comment:3 follow-up: ↓ 4 Changed 5 years ago by andy
All the pieces needed to do this are already provided by the kernel, it's up to userspace to react to the power button press like that. Carsten seems to deal with this end.
comment:4 in reply to: ↑ 3 Changed 5 years ago by raster
that is currently exactly what is happening. ompower forcible switches backlight to off just before a suspend and foricbly turns it on when resuming. the turn on on resume should be logic based on resume reason. ompower should broadcast dbus messages as to resume reason (right now i still dont get any sensible resume reason and i reflashed my uboot to a new version last week or so), so i can't do much there right now, but the bahavior now is exactly like if the kernel did it, but we definitely have no flickering on/off of backlights and seeing the graphics go garbage etc. on suspend or resume. its slick off/on of the screen and brightness stays where it was on suspend.
comment:5 Changed 5 years ago by andy
Carsten, flickering of backlights and garbage framebuffer are already fixed in kernel directly without your daemon.
Please post about the resume reason stuff to the kernel list describing what you are doing and showing the results.
comment:8 Changed 5 years ago by wendy_hung
- Status changed from in_testing to closed
- Resolution set to fixed
Tested with the image below:
kernel:20080723-asu.stable-uImage.bin
root file system:20080805-asu.stable-rootfs.jffs2
Now we can do the suspend/resume by the power button, but still bug relate to #1685.
Tuesday I found a patch that was missed off stable branch from andy a couple of weeks ago that deals with this and added it in.
http://git.openmoko.org/?p=kernel.git;a=commitdiff;h=e1673170182af199be7c6a2a346d8bad7e4dc532
Try again with a kernel built in last 24 hours and the noise crap should be gone (again, this patch fixed it on andy for many weeks). If not, you need to explain more about it because it is something new.