Ticket #172 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

missing openmoko-dialer-window-pin.o breaks build

Reported by: werner@… Owned by: tonyguan@…
Priority: highest Milestone:
Component: openmoko-dialer Version: current svn head
Severity: blocker Keywords:
Cc: buglog@… Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: PatchReviewResult:
Reproducible:

Description

Current openmoko-devel-image build fails due to missing file.
Work-around (this gets us past the build failure, no idea what else
may crawl out of this, though):

  • remove references to openmoko-dialer-window-pin from src/Makefile
  • comment out call to window_pin_init in openmoko-dialer-main.c

Change History

comment:1 Changed 6 years ago by mickey@…

Applied the said workaround. Tony, please fix it properly. You'll see the
#warning parts I've inserted in the sourcecode.

comment:2 Changed 6 years ago by werner@…

Note: I think the change to pin.c wasn't unnecessary, but I don't want to
revert this now, because I'd prefer to avoid making changes to other people's
code if they aren't strictly needed at this time. Just to let you know, in
case you're wondering what happened there.

comment:3 Changed 6 years ago by tonyguan@…

  • Status changed from new to closed
  • Resolution set to fixed

Yes, I added it now. Last Friday, our network was down so that I could not
commit till today.

Note: See TracTickets for help on using tickets.