Ticket #1786 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

GtkButton inner_border theme change

Reported by: montgoss Owned by: openmoko-devel
Priority: normal Milestone:
Component: unknown Version: Om2008.8
Severity: trivial Keywords: gtk,theme,inner_border, HasPatch
Cc: montgoss, mickeyl@… Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: PatchReviewResult:
Reproducible:

Description

gtkrc seems to have changed between OM2007.2 and Om2008.8. In particular, the GtkButton::inner_border was changed from:
GtkButton::inner_border = {10, 10, 10, 10}
to:
GtkButton::inner_border = {15, 15, 10, 10}

This breaks the layout of several apps that would otherwise work fine on both distros. However, even reverting back to all 10's is an issue (perhaps some other change in the file is affecting it). All 5's works, but others like all 1's. This should be a simple change that would make it a lot easier for developers to support multiple distros.

Attachments

gtkrc.diff (712 bytes) - added by rost 6 years ago.
Patch for gtkrc

Change History

comment:1 Changed 6 years ago by zecke

  • Cc mickeyl@… added
  • Milestone OM-2008.8 deleted

Hmm. IIRC we install openmoko-theme-standard2, which is getting the source from http://svn.openmoko.org/trunk/src/target/OM-2007.2/artwork/themes/openmoko-standard-2 and we use the revision r4338. If you provide a patch we could find someone to review, put that into the SVN and provide upgraded packages. It is definitely not the area of my knowledge.

Mickey do you still remember this stuff?

Changed 6 years ago by rost

Patch for gtkrc

comment:2 Changed 6 years ago by rost

I just attached a patch for gtkrc. I just tested it with tangoGPS. Before applying the patch tangoGPS was unusable, now it runs fine.

comment:3 Changed 6 years ago by zecke

  • Keywords gtk,theme,inner_border, HasPatch added; gtk,theme,inner_border removed

comment:4 Changed 6 years ago by erin_yueh

please update it to moko-gtk-theme revision 4411! this theme is fine.
i would notify distro team to update moko-gtk-theme version. In our daily images, the version of moko-gtk-theme and moko-gtk-enginer are different, still using the old one. Your patch file is based on the old one, not new one. Update it to the latest one, then it can solve your problem.

comment:5 Changed 6 years ago by erin_yueh

  • Status changed from new to closed
  • Resolution set to fixed

this new version is still in testing repository, you may get opk file from here:
http://downloads.openmoko.org/repository/testing/armv4t/moko-gtk-theme_0.1.0+svnr4411-r0_armv4t.opk

Note: See TracTickets for help on using tickets.