Ticket #1831 (closed defect: fixed)
please remove dependency between mediaplayer and pulseaudio in 2008.8
| Reported by: | hedora | Owned by: | john_lee |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | unknown | Version: | |
| Severity: | normal | Keywords: | HasPatch |
| Cc: | Blocked By: | ||
| Blocking: | Estimated Completion (week): | ||
| HasPatchForReview: | yes | PatchReviewResult: | |
| Reproducible: |
Description
mediaplayer is hardcoded to use a pulseaudio sink. In SHR (which does not use pulseaudio), it should default to an alsasink instead. The difference is a two line patch, which changes this line in playback.c:
omp_gst_audiosink = gst_element_factory_make("pulsesink", NULL);
to read "pulsesink" instead of "alsasink". (See attachment for the error message that should change...)
If you'd like to avoid hardcoding this configuration option, I think you can pass NULL in instead of "pulsesink", and gstreamer will attempt to "do the right thing", which can be overridden by the user by setting an environment variable.
Then the dependency between it and pulseaudio can be removed from the 2008.8 package.
Also, I have been told that mediaplayer works under 2008.8 without openmoko-sound-system2 installed. Consider removing that dependency as well.
Thanks!
Attachments
Change History
Changed 5 years ago by hedora
- Attachment openmoko-mediaplayer2-performance-workaround.patch added
comment:2 Changed 5 years ago by roh
- HasPatchForReview set
BatchModify?: set HasPatchForReview? on 'keyword' contains 'patch'

(inappropriatetly named; in 2008, this patch does 'the right thing'; it's was a 'workaround' in 2007.2)