Ticket #1833 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

Getting rid of battery and usb useless dbus related debug output

Reported by: LeRoutier Owned by: openmoko-devel
Priority: normal Milestone:
Component: unknown Version:
Severity: normal Keywords: HasPatch
Cc: Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: yes PatchReviewResult:
Reproducible:

Description

Both matchbox's applets for USB and Battery fill logs because of the way they handle DBus messages.

They recieve messages from everyone, not only for the waited Interface. So, each time a Hal or Freesmartphone or whatever dbus message arrives, they put a "Unknown dbus message, ignoring" in /tmp/x.log, making it useless.

The following patches would limit the noise.

Attachments

openmoko-panel-battery_dbus_debug.patch (2.0 KB) - added by LeRoutier 10 years ago.
openmoko-panel-battery patch
openmoko-panel-usb_dbus_debug.patch (1.7 KB) - added by LeRoutier 10 years ago.
openmoko-panel-usb patch
openmoko-dialer2_dbus_debug.patch (2.7 KB) - added by LeRoutier 10 years ago.
openmoko-dialer2_dbus patch

Change History

Changed 10 years ago by LeRoutier

openmoko-panel-battery patch

Changed 10 years ago by LeRoutier

openmoko-panel-usb patch

comment:1 Changed 10 years ago by LeRoutier

To be more precise, for each unknown dbus message, we had :

(matchbox-panel-2:1542): DEBUG: battery_applet: signal_filter
(matchbox-panel-2:1542): DEBUG: (unknown dbus message, ignoring)
(matchbox-panel-2:1542): DEBUG: usb_applet: signal_filter
(matchbox-panel-2:1542): DEBUG: (unknown dbus message, ignoring)

in /tmp/x.log

Whatever the source or dest of the message was

comment:2 Changed 10 years ago by LeRoutier

Please note that openmoko-dialer2 (phone-kit) needs the same kind of love :

if ( !g_strcmp0( dbus_message_get_interface(msg), "org.openmoko.PhoneKit?.Headset" ) ) { ... }

Changed 10 years ago by LeRoutier

openmoko-dialer2_dbus patch

comment:3 Changed 10 years ago by zecke

  • Keywords HasPatch added

comment:4 Changed 10 years ago by roh

  • HasPatchForReview set

BatchModify?: set HasPatchForReview? on 'keyword' contains 'patch'

comment:5 Changed 10 years ago by erin_yueh

  • Status changed from new to closed
  • Resolution set to fixed

patches committed in r4778,4779,4780.

Note: See TracTickets for help on using tickets.