Ticket #186 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

Fingerbubbles take endless amount of ram and get OOMed

Reported by: koen@… Owned by: thomas@…
Priority: high Milestone:
Component: openmoko-libs Version: current svn head
Severity: normal Keywords:
Cc: buglog@… Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: PatchReviewResult:
Reproducible:

Description

(Sorry if I have the wrong product)

The finger scrollwheel works great, but if I open the thing with the bubbles it
will start filling my RAM (64MB) and swap (256MB) and gets OOM'ed a while later.

Tested on an ipaq hx4700 running the angstrom distribution.

Change History

comment:1 Changed 6 years ago by mickey@…

  • Owner changed from mickey@… to thomas@…

A binary search resulted in svn diff -r982:983 to be responsible. I have
reverted this patch and reassign this bug to thomas -- please have a look.

comment:2 Changed 6 years ago by koen@…

  • Status changed from new to closed
  • Resolution set to fixed

A binary search resulted in svn diff -r982:983 to be responsible. I have
reverted this patch and reassign this bug to thomas -- please have a look.

Works fabulous!

comment:3 Changed 6 years ago by mickey@…

  • Status changed from closed to reopened
  • Resolution fixed deleted

Sorry, closed unintentionally. Thanks Ross for spotting.

comment:4 Changed 6 years ago by koen@…

Sorry, closed unintentionally. Thanks Ross for spotting.

But it works now: http://www.flickr.com/photos/koenkooi/391406865/ :)

comment:5 Changed 6 years ago by thomas@…

  • Status changed from reopened to closed
  • Resolution set to fixed

I've just committed a fix for this. The original patch (to MokoAlignment?)
removed the need for accessing the parent widget's private struct, but by using
the set_padding method, caused a size request inside the size request function.
I have fixed this and re-applied the patch.

Ideally the padding style property should not be re-read each time a size
request is called. We also noticed that gtk_widget_show and gtk_widget_hide are
being used inside the MokoFingerToolBox? size request, which could cause a
size_request in itself, leading to another loop.

Note: See TracTickets for help on using tickets.