Ticket #1878 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

infinite recursion in om-locations-map-pack.c

Reported by: xbaldauf Owned by: olv@…
Priority: normal Milestone: Om2008.9
Component: Locations Version: Om2008.8
Severity: normal Keywords:
Cc: jeremy@… Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: PatchReviewResult:
Reproducible:

Description

In ​http://git.openmoko.org/?p=om-locations.git;a=blob;f=tools/om-locations-map-pack.c;h=4fefe1181db9450b64ce48c6a9d23b7242d73ca3;hb=HEAD

function fetch_sched() may call fetch_completion() (in line 351), while
function fetch_completion() may call fetch_sched() (in line 312).

This leads to infinite recursion if the "circumstances" are right.

One of these circumstances is if om-locations-map-pack is run over a sufficiently large cache directory (with more than 2000 tiles).

Thus, this bug prevents incremental downloading of reasonably sized tile sets (e.g. a tile set of a larger city).

Attachments

om-locations-map-pack.c.fixInfiniteRecursion.diff​ (2.0 KB) - added by xbaldauf 5 years ago.
Fix for the bug.

Change History

Changed 5 years ago by xbaldauf

Fix for the bug.

comment:1 Changed 5 years ago by marek

  • Status changed from new to assigned
  • Owner changed from marek to jeremy
  • Milestone changed from Om2008.8 to Om2008.9

comment:2 Changed 5 years ago by olv

  • Status changed from assigned to in_testing

Thanks for pointing out. 665e46ef6e76b414a055945761eed7e82fc5cead should fix the problem.

comment:3 Changed 5 years ago by jeremy

  • Status changed from in_testing to assigned
  • Owner changed from jeremy to olv@…
  • Cc jeremy@… added

Add OLV in.

comment:4 Changed 5 years ago by jeremy

  • Status changed from assigned to in_testing

goes to testing

comment:5 Changed 5 years ago by wendy_hung

  • Status changed from in_testing to closed
  • Resolution set to fixed

thanks for your help, jeremy!

Note: See TracTickets for help on using tickets.