Ticket #1970 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

ar6k does not print newline after disconnect message

Reported by: mattb Owned by: openmoko-kernel
Priority: normal Milestone:
Component: kernel Version: Om2008.9-dev
Severity: normal Keywords: HasPatch
Cc: Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: PatchReviewResult:
Reproducible: always

Description

This is purely cosmetic, but annoying.

The ar6k wifi driver does not print a newline after the informational message when disconnecting from an AP. This leads to cluttered dmesg output like the following:

AR6000 disconnected from 00:02:cf:85:c6:08 AR6000 connected event on freq 2412 with bssid 00:02:cf:85:c6:08 listenInterval=100, beaconInterval = 100, beaconIeLen = 0 assocReqLen=27 assocRespLen =22

What is expected, is something like:

AR6000 disconnected from 00:02:cf:85:c6:08
AR6000 connected event on freq 2412 with bssid 00:02:cf:85:c6:08 listenInterval=100, beaconInterval = 100, beaconIeLen = 0 assocReqLen=27 assocRespLen =22

The upside of this is that it gives me a nice simple patch to send in as my first contribution to OpenMoko?.

Cheers

Attachments

newline_after_disconnect_msg.patch​ (490 bytes) - added by mattb 5 years ago.
Add a newline after printing the disconnect message

Change History

Changed 5 years ago by mattb

Add a newline after printing the disconnect message

comment:1 Changed 5 years ago by andy

  • Status changed from new to closed
  • Resolution set to fixed

Thanks, I sent it into stable kernel branch.

Note: See TracTickets for help on using tickets.