Ticket #1976 (new enhancement)

Opened 10 years ago

Last modified 10 years ago

Redial last called number

Reported by: Treviño Owned by: zecke
Priority: normal Milestone:
Component: Qtopia Version: Om2008.8
Severity: normal Keywords: HasPatch, PM
Cc: Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: yes PatchReviewResult:
Reproducible:

Description

I've made a small patch to allow to redial the latest dialed number.

There's just only a thing that should be improved: in my tests the number is redialed only after that a first call is made; maybe this is due to the fact that the LastDialedCall? value is set only after the first call.
I figure that a better implementation (but maybe slower?) would be getting all the QCallList::Dialed items and then rewriting just the first value. Should be this the right way?

Attachments

qtopia-redial-last-call.patch (699 bytes) - added by Treviño 10 years ago.
Redial the latest dialed number - Touchscreen keypad patch.

Change History

Changed 10 years ago by Treviño

Redial the latest dialed number - Touchscreen keypad patch.

comment:1 follow-up: ↓ 2 Changed 10 years ago by zecke

  • Keywords HasPatch added

@Implementation: It is fine, maybe the valuespace is not populated from the callhistory
@Approach:

  • Yes, redial is one thing I miss a lot...
  • Having a feature that is not easy to discover (no button for it), that can be accidently triggered (someone pressed call with an empty number accidently and then a complete number gets dialer) are violations of common usability standards.

@Proposal: Add a redial action to the menu of the dialer. This will take two clicks (open menu, click on redial) and we can consider exchanging the SMS button with the redial action (easy once the code for the action is there) in the future. Would you be willing to give that a try?

comment:2 in reply to: ↑ 1 ; follow-up: ↓ 3 Changed 10 years ago by Treviño

Replying to zecke:

@Implementation: It is fine, maybe the valuespace is not populated from the callhistory

No, it isn't... What do you think about implementing the "search-last-dialed-number" feature? Do you think it would be much slower?

@Approach:

  • Having a feature that is not easy to discover (no button for it), that can be accidently triggered (someone pressed call with an empty number accidently and then a complete number gets dialer) are violations of common usability standards.

Well, that's not completely true... Yes, there's no button for it, but redialing pressing the "green button" is a common phone feature. However With my patch to re-dial the "LastDialedCall?" you need to press the call button twice, not once!
In fact, if the text string is empty and you press the call button, that text area just populated with the latest called string. If you want to dial that number, instead, you've to press the call button another time. I think that this is a reasonable approach.

@Proposal: Add a redial action to the menu of the dialer. This will take two clicks (open menu, click on redial) and we can consider exchanging the SMS button with the redial action (easy once the code for the action is there) in the future. Would you be willing to give that a try?

I could do it, but imho adding a button is redundant while using the menu action is not so intuitive. I'd exchange the SMS button with a "clear number", instead...

comment:3 in reply to: ↑ 2 ; follow-up: ↓ 4 Changed 10 years ago by zecke

  • Keywords HasPatch, PM added; HasPatch removed

Replying to Treviño:

Replying to zecke:

@Implementation: It is fine, maybe the valuespace is not populated from the callhistory

No, it isn't... What do you think about implementing the "search-last-dialed-number" feature? Do you think it would be much slower?

No, finding the last dialed number of the callhistory should be quite easy and fast enough. The question is if you want to have redial around reboots but it would not hurt.

@Approach:

  • Having a feature that is not easy to discover (no button for it), that can be accidently triggered (someone pressed call with an empty number accidently and then a complete number gets dialer) are violations of common usability standards.

Well, that's not completely true... Yes, there's no button for it, but redialing pressing the "green button" is a common phone feature. However With my patch to re-dial the "LastDialedCall?" you need to press the call button twice, not once!
In fact, if the text string is empty and you press the call button, that text area just populated with the latest called string. If you want to dial that number, instead, you've to press the call button another time. I think that this is a reasonable approach.

Yes, but that is a hardware button in most cases and I doubt the "Call" button in the UI has the same functionality?

@Proposal: Add a redial action to the menu of the dialer. This will take two clicks (open menu, click on redial) and we can consider exchanging the SMS button with the redial action (easy once the code for the action is there) in the future. Would you be willing to give that a try?

I could do it, but imho adding a button is redundant while using the menu action is not so intuitive. I'd exchange the SMS button with a "clear number", instead...

I added PM as I don't want to make a decision on that. I will talk with some local folks about it as well.

comment:4 in reply to: ↑ 3 Changed 10 years ago by Treviño

Replying to zecke:

Replying to Treviño:

Replying to zecke:

@Implementation: It is fine, maybe the valuespace is not populated from the callhistory

No, it isn't... What do you think about implementing the "search-last-dialed-number" feature? Do you think it would be much slower?

No, finding the last dialed number of the callhistory should be quite easy and fast enough. The question is if you want to have redial around reboots but it would not hurt.

I figure that it should be useful having a redial after reboot... So ASAP I'll try to parse the last call from the history.

@Approach:

  • Having a feature that is not easy to discover (no button for it), that can be accidently triggered (someone pressed call with an empty number accidently and then a complete number gets dialer) are violations of common usability standards.

Well, that's not completely true... Yes, there's no button for it, but redialing pressing the "green button" is a common phone feature. However With my patch to re-dial the "LastDialedCall?" you need to press the call button twice, not once!
In fact, if the text string is empty and you press the call button, that text area just populated with the latest called string. If you want to dial that number, instead, you've to press the call button another time. I think that this is a reasonable approach.

Yes, but that is a hardware button in most cases and I doubt the "Call" button in the UI has the same functionality?

Imho it's the same... All the people tried my phone, instinctively, pressed that button to redial a number; that's why I've added this kind of implementation.
I don't think that nowadays people see so much difference in a hardware and software buttons...

@Proposal: Add a redial action to the menu of the dialer. This will take two clicks (open menu, click on redial) and we can consider exchanging the SMS button with the redial action (easy once the code for the action is there) in the future. Would you be willing to give that a try?

I could do it, but imho adding a button is redundant while using the menu action is not so intuitive. I'd exchange the SMS button with a "clear number", instead...

I added PM as I don't want to make a decision on that. I will talk with some local folks about it as well.

Of course... BTW, let us (me) know about this decision! :)

comment:5 Changed 10 years ago by roh

  • HasPatchForReview set

BatchModify?: set HasPatchForReview? on 'keyword' contains 'patch'

Note: See TracTickets for help on using tickets.