Ticket #2340 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

glamo-mci should use MODULE_DEVICE_TABLE

Reported by: ThibG Owned by: openmoko-kernel
Priority: normal Milestone:
Component: kernel Version: unspecified
Severity: normal Keywords:
Cc: Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: yes PatchReviewResult:
Reproducible:

Description

Hi,
in order to be auto-loaded by udev, the glamo-mci driver should use MODULE_DEVICE_TABLE.
Here is a patch.

Attachments

register-glamo-mci.patch​ (507 bytes) - added by ThibG 3 years ago.
register-glamo.patch​ (760 bytes) - added by ThibG 3 years ago.

Change History

Changed 3 years ago by ThibG

comment:1 Changed 3 years ago by lars

Hi,

MODULE_ALIAS("platform:...") should have the same effect and is much more readable. Could you test and resend a patch with MODULE_ALIAS instead of MODULE_DEVICE_TABLE? It would be great if you could do it for all the glamo modules which don't have it yet.

Thanks,
-Lars

comment:2 Changed 3 years ago by ThibG

Yes, indeed, MODULE_ALIAS is sufficient for the glamo modules, and much more readable.
Here is a new patch, using MODULE_ALIAS, for glamo-mci and glamo-fb. glamo-core and glamo-gpio already have the MODULE_ALIAS thing.

Changed 3 years ago by ThibG

comment:3 Changed 3 years ago by lars

  • Status changed from new to closed
  • Resolution set to fixed

Hi

Thanks, I applied your patch.

  • Lars
Note: See TracTickets for help on using tickets.