Ticket #267 (closed enhancement: fixed)

Opened 6 years ago

Last modified 6 years ago

internal function duplicates strstr(3)

Reported by: rodolphe.ortalo@… Owned by: buglog@…
Priority: low Milestone:
Component: openmoko-messages Version: current svn head
Severity: minor Keywords: VERIFIED
Cc: buglog@… Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: PatchReviewResult:
Reproducible:

Description

In openmoko-messages' src/main.c, it seems to me that the function in_string
duplicates the libc builtin function strstr(3).
Unless these functions are not available on the embedded system (special libc?),
maybe it could be replaced. Furthermore, in the attached patch, I replaced it by
strcasestr(3) which allow case-insensitive search.

Attachments

om-messages-strstr.patch​ (1.3 KB) - added by rodolphe.ortalo@… 6 years ago.
in_string replace by strcasestr

Change History

Changed 6 years ago by rodolphe.ortalo@…

in_string replace by strcasestr

comment:1 Changed 6 years ago by alex@…

  • Status changed from new to closed
  • Resolution set to fixed

Use strcasestr instead of in_string

comment:2 Changed 6 years ago by rodolphe.ortalo@…

  • Keywords VERIFIED added
Note: See TracTickets for help on using tickets.