Ticket #512 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

moko_scrolled_pane_get_scrolled_window is bad API

Reported by: rob@… Owned by: mickey@…
Priority: high Milestone:
Component: openmoko-libs Version: unspecified
Severity: normal Keywords:
Cc: buglog@…, thomas@… Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: PatchReviewResult:
Reproducible:

Description

I assume the point of this function is to get the scrolled window so that one
can add a widget to it, e.g. a TreeView?. This seems pretty bad since you are
exposing some of the internals. I

Having consulted with my resident GTK hacker he would suggest adding a

void moko_scrolled_pane_pack (MokoScrolledPane? *pane, GtkWidget? *child)
and
void moko_scrolled_pane_unpack (MokoScrolledPane? *pane, GtkWidge? *child)
and
GtkWidget? *moko_scrolled_pane_get_child (MokoScrolledPane? *pane)

Code ready to commit when you say so.

Change History

comment:1 Changed 6 years ago by mickey@…

Agreed. Please go ahead.

comment:2 Changed 6 years ago by rob@…

  • Status changed from new to closed
  • Resolution set to fixed

Committed to SVN.

Note: See TracTickets for help on using tickets.