Ticket #531 (closed defect: invalid)
make and configure modifications for make distcheck
| Reported by: | rodolphe.ortalo@… | Owned by: | thomas@… |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | openmoko-contacts | Version: | current svn head |
| Severity: | minor | Keywords: | |
| Cc: | buglog@… | Blocked By: | |
| Blocking: | Estimated Completion (week): | ||
| HasPatchForReview: | PatchReviewResult: | ||
| Reproducible: |
Description
one .desktop.in file was missing in the build files for make dist or make
distcheck to succeed
I also propose to use the "dist_" prefix to simplify Makefile.am
intltool .in files are not included in svn - they are not needed for building
either - so the patch deactivates the IT_PROG_INTLTOOL macro in configure.ac and
the additional clean commands.
With these modifications, make distcheck should run correctly
Attachments
Change History
Changed 6 years ago by rodolphe.ortalo@…
- Attachment contacts_making.patch added
comment:1 Changed 6 years ago by thomas@…
"make distcheck" works fine for me from a clean source tree. What problems were
you having?
comment:2 Changed 6 years ago by rodolphe.ortalo@…
make distcheck fails for me: first on the intltool macros (says the .in
files are not available) and then on the .desktop (says .in file isn't
either).
Note that I am building in a separate build directory.
Strange that you do not reproduce that easily...
NB: I think I understood how to add a comment to the bug in bugzilla... (That's
just too simple it seems... ;-)
comment:3 Changed 6 years ago by rodolphe.ortalo@…
- Status changed from new to closed
- Resolution set to invalid
OK. I understood my mistake: I do not run the autogen.sh scripts because they
configures the source tree and prevents me from building in a separate build
directory.
However, in the case of openmoko-contacts, autogen.sh calls gnome-autogen.sh,
which does much more things than the usual autogen.sh of other OpenMoko?
components; including running intltoolize to create the files that were missing
in my initial setup...
So, in fact, the only thing I really need to build in a separate directory is
the following (self-explaining) modification :
Index: autogen.sh
===================================================================
--- autogen.sh (révision 1897)
+++ autogen.sh (copie de travail)
@@ -18,6 +18,6 @@
echo "You need to install gnome-common from the GNOME CVS"
exit 1
}
-USE_GNOME2_MACROS=1 . gnome-autogen.sh
+NOCONFIGURE=1 USE_GNOME2_MACROS=1 . gnome-autogen.sh
===================================================================
Then I run your autogen.sh and I run configure manually in my build tree (or
just call make).
OK. I think I am going to close the bug maybe even mark it invalid...
(NB: Note the dist_ automake prefix could be used in data/Makefile.am - see the
end of my original changes - IMHO it simplifies maintainance.)

patch for make distcheck