Ticket #631 (closed defect: wontfix)

Opened 12 years ago

Last modified 12 years ago

[Patch/Cleanup] No segfault when dbus not running

Reported by: elrond+bugzilla.openmoko.org@… Owned by: thomas@…
Priority: high Milestone:
Component: openmoko-dialer Version: unspecified
Severity: minor Keywords:
Cc: buglog@… Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: PatchReviewResult:
Reproducible:

Description

The dialer can segfault, when there is no dbus running/runnable.

The main problem is calling org_freedesktop_DBus_request_name with proxy==NULL
and later looking at error (which is not properly set).

This patch stops this and factors the dbus setup partly out of main().

It also lets the dialer work _somewhat_ in this situation. That means, that the
dialer pops up immediately (so it can be used at all).
Letting the dialer work in this situation should not be considered a problem:

  • The changes needed to get this "feature" are minimal and non-invasive
  • They don't hurt
  • This is not a standard situation, so if the "feature" later breaks, it does't hurt either. (read: Nobody should care to hold this feature working)

In one sentence: It's currently "free" and involves no later "costs".

Attachments

dialer-dbus-fixes.diff (3.2 KB) - added by elrond+bugzilla.openmoko.org@… 12 years ago.
dialer-dbus-fixes.diff

Change History

Changed 12 years ago by elrond+bugzilla.openmoko.org@…

dialer-dbus-fixes.diff

comment:1 Changed 12 years ago by njp@…

  • Status changed from new to closed
  • Resolution set to wontfix

No valid for OM-2007.2.

Note: See TracTickets for help on using tickets.