openmoko-dialer2 segfaults when first digit entered is '#'

[cwixon@…]

Version is 0.1.0+svnr2869-r5

I can enter numeric digits (and dial) successfully.

But to check my GSM account balance I need to dial #999#, and it crashes
(segfault, according to the terminal) as soon as I hit that first '#'.

[cw@…]

0.1.0+svnr2869-r5 works here and doesn't crash for me (i don't get the network
information back, but i can see it in the logs)

perhaps (when you get a chance) can you update and retest this and verify it
still crashes for you?

[cwixon@…]

It's very repeatable, even immediately after a reboot.

Unfortunately I don't see any logs that might shed more light on the situation.

All I get on the terminal display -- if I happened to have restarted

openmoko-dialer from there -- is the segfault message. And I should add,
sometimes it takes other things down with it, such as the Window Manager.

I have seen a lot of check-ins on the dialer lately, so I'll verify again after
I'm able to upgrade it. (I haven't been able to complete a build in the last
couple of days, I think because of ${SRCREV} gremlins.)

[thomas@…]

I committed several fixes which have meant I am no longer able to reproduce this
bug. Please re-open if you can still reproduce this bug with the latest version
of the software.

[cwixon@…]

Works for me now. Thanks, nice job.

[roman.moravcik@…]

After i've got dialer history working, I can reproduce this segfault.

[thomas@…]

The digits array is defined as having 11 elements, so accessing the 12th element
is not going to be a good idea. I think moko_contacts_fuzzy_lookup() should
probably just return NULL if it can't convert the character to a digit.

[roman.moravcik@…]

[PATCH] 5/5 Fix segfaults whne first digit entered is '#' (2)

[thomas@…]

Patch comitted (r3085), thanks.