Ticket #812 (assigned defect)

Opened 6 years ago

Last modified 5 years ago

"neo1973 gsm version" command does not respond

Reported by: thomas@… Owned by: openmoko-kernel
Priority: high Milestone:
Component: u-boot Version:
Severity: normal Keywords: Patch
Cc: buglog@… Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: yes PatchReviewResult:
Reproducible:

Description

The following sequence entered into the u-boot console causes u-boot to become
unresponsive:

GTA01Bv4 # neo1973 gsm on
GTA01Bv4 # neo1973 gsm version
switching s3ser0 from console into GSM mode
GSM firmware version:

Attachments

gsmver.patch (1.8 KB) - added by frances.albanese 5 years ago.
Patch for gsmver (u-boot 1.3.2)

Change History

comment:1 Changed 6 years ago by thomas@…

U-Boot GTA01Bv4 # version

U-Boot 1.2.0-g60174746-dirty-moko11 (Sep 5 2007 - 00:53:30)

comment:2 Changed 6 years ago by laforge@…

  • Owner changed from laforge@… to jserv@…

reassigning this to jserv, he wrote the code, IIRC.

comment:3 Changed 6 years ago by jserv@…

  • Status changed from new to assigned

comment:4 Changed 6 years ago by jserv@…

The bug was resulted from the fixes of bugzilla #205. It can be re-produce on
GTA02v2, but can not show up here for tested 3 GTA01 machines including GTA01bv4
and GTA01bv3. I need to confirm the proper timing while GSM passthrough mode
was implemented.

comment:5 Changed 6 years ago by laforge@…

I have just tried to fix it, but it still doesn't work on my GTA01Bv4.

My old original firmware does not contain any double-quotes (") so jserv's
original code would wait indefinitely for them.

But for some strange reason, even though "neo1973 gsm on; terminal s3ser0;
AT+CGMR;" gives a good result, the "neo1973 gsm version" still doesn't work.

So I leave this bug open. Would be great if somebody from jserv's team can look
into it.

comment:6 Changed 6 years ago by kousue@…

Using u-boot-gta01bv4-1.2.0+git20070917+svnr2943-r0.bin this bug still shows up.
I have a GTA01Bv4.

comment:7 Changed 6 years ago by jserv@…

Thanks for the feedbacks. The primary reason might result from new GSM firmware
our internal S/W team members are using. I'll roll back to the very old one in
order to clarify.

comment:8 Changed 5 years ago by willie_chen@…

  • Owner changed from jserv@… to willie_chen@…
  • Status changed from assigned to new

comment:9 Changed 5 years ago by andy@…

What did you find out Jim from the old firmware test?

comment:10 Changed 5 years ago by mail@…

Part of the problem is that gsmver.c now contains a while() loop that will never
exit (as of svn 3184):

while (1) {

if (dev->tstc()) {

i = dev->getc();
putc(i);
/* FIXME: should we just dump straightforward

  • version string such as "moko1" or "moko4"? */
if (i == '\n'
i == '\r')

continue;

}

}

However there is also some other problem because I do not see any response from
the modem (it hangs after printing "GSM Firmware Version:", as shown in the
first comment). I can execute the "AT+CGMR" command manually through the terminal.

My versions:
U-Boot 1.3.1+git20080106+svnr3776 (Jan 6 2008 - 15:22:25)
+CGMR: "HW: GTA01Bv4, GSM: gsm_ac_gp_fd_pu_em_cph_ds_vc_cal35_ri_36_amd8_ts0-Moko1"

Changed 5 years ago by frances.albanese

Patch for gsmver (u-boot 1.3.2)

comment:11 in reply to: ↑ description Changed 5 years ago by frances.albanese

  • Keywords Patch added
  • Status changed from new to in_testing
  • Version changed from current svn head to GTA01Bv4

Replying to thomas@openedhand.com:

The following sequence entered into the u-boot console causes u-boot to become
unresponsive:

GTA01Bv4 # neo1973 gsm on
GTA01Bv4 # neo1973 gsm version
switching s3ser0 from console into GSM mode
GSM firmware version:

Check out the enclosed the patch for a possible fix (tested on GTA01bv4).

Greetings

FA

comment:12 Changed 5 years ago by roh

  • Owner changed from willie_chen@… to willie_chen

comment:13 Changed 5 years ago by regina_kim

hey thomas~

please check this ticket.

comment:14 Changed 5 years ago by roh

  • HasPatchForReview set

BatchModify?: set HasPatchForReview? on 'keyword' contains 'patch'

comment:15 Changed 5 years ago by regina_kim

i will close in 7days if nobody verify this ticket.

comment:16 Changed 5 years ago by john_lee

  • Owner changed from willie_chen to openmoko-kernel
  • Status changed from in_testing to assigned
  • Version GTA01Bv4 deleted

I confirm this issue still exists on gta02. Could someone review the patch?

Note: See TracTickets for help on using tickets.