Ticket #866 (closed defect: later)
No number entered should recall last dialed number when tapping Dial
| Reported by: | hrw@… | Owned by: | thomas@… |
|---|---|---|---|
| Priority: | high | Milestone: | |
| Component: | openmoko-dialer | Version: | unspecified |
| Severity: | wishlist | Keywords: | |
| Cc: | buglog@…, kresp0@… | Blocked By: | |
| Blocking: | Estimated Completion (week): | ||
| HasPatchForReview: | PatchReviewResult: | ||
| Reproducible: |
Description
One shy developer told that when no number entered should recall last dialed
number when tapping Dial.
Attachments
Change History
comment:2 Changed 6 years ago by graeme@…
Recall the last dialed would echo the behaviour of every phone I have ever owned.
comment:3 Changed 6 years ago by chris@…
Every phone I've owned (ranging across Ericsson, Sony Ericsson, Siemens, Nokia,
Motorola, Philips and Samsung) shows the last-dialled call history when I press
the dial button with no number input.
I think this is good behaviour - I usually only dial 3 or 4 numbers, but I don't
often dial the same number twice in a row (and I imagine this is the pattern for
a lot of other mobile-phone users) - this works great for that situation and if
you do tend to just dial one number, it's only one extra key-press anyway.
comment:4 Changed 6 years ago by hrw@…
Graeme: This is true on phones which give you call history when you press DIAL
button. Neo gives DialPad? instead.
comment:5 Changed 6 years ago by mickey@…
Showing the last number on first tap of dial, then being able to change this
before pressing dial for the 2nd time, is what I would prefer. Please make it so
and let's reconsider if we get lots of complaints (which I doubt).
Changed 6 years ago by roman.moravcik@…
- Attachment dial_last_called_number.patch added
Show dialed history on dialing empty number
comment:7 Changed 6 years ago by thomas@…
- Status changed from new to closed
- Resolution set to later
I've committed Roman's patch, but altered it slightly to select the first item
in the on_filter_changed() callback rather than in moko_history_set_filter().
This is more desirable as it also makes sure an item is always selected when the
user changes the filter.
Although this doesn't resolve the feature request exactly as described, I think
it is a better situation that trying to dial a blank number. It also solves the
problem of having no previously dialed numbers by displaying this information
rather than attempting to fill in the dialer display.

I think that by default Dial button should be disabled - we have calls history
on second tab.