Ticket #928 (closed defect: fixed)

Opened 12 years ago

Last modified 11 years ago

implement AT command interrupt/cancel

Reported by: Tuukka.Hastrup@… Owned by: tick@…
Priority: high Milestone:
Component: gsmd Version: current svn head
Severity: critical Keywords:
Cc: buglog@…, balrogg@…, tick@…, mstevens@… Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: PatchReviewResult:
Reproducible:

Description

Currently we can't cancel outgoing calls before they are answered, which is
critical. (For the issue history, please see #906.)

AT commands that take a long time could be cancelled by a simple "AT", or in
case of ATD, ATH would be good. However, gsmd makes sure that applications don't
cancel one another's commands. It issues the next command only after the
previous completes.

A simple workaround for now would be to remove "AT+COLP=1" from the modem init
at gsmd/gsmd.c - this makes ATD return immediately. At least in my tests, the
info lost is just +COLP: "",128, and we don't process that in libmokogsmd or the
dialer anyway.

In the long term, gsmd should get COLP back and support cancelling commands such
as AT+COPS=? too.

Attachments

0001-Implement-atcmd_cancel-and-VOICECALL_HANGUP-throug.patch (5.6 KB) - added by balrogg@… 11 years ago.
Implement atcmd cancelling and VOICECALL_HANGUP
cancel_atcmd.patch (6.1 KB) - added by tick@… 11 years ago.
cancel_atcmd

Change History

comment:1 Changed 12 years ago by Tuukka.Hastrup@…

  • blocked set to 906

comment:2 Changed 12 years ago by balrogg@…

  • Cc balrogg@… added

comment:3 Changed 12 years ago by mstevens@…

  • Cc mstevens@… added

comment:4 Changed 12 years ago by tick@…

  • Cc ticktock35@… added

comment:5 Changed 11 years ago by mickey@…

  • Owner changed from laforge@… to jserv@…

jserv or tick, can we use this implementation?

comment:6 Changed 11 years ago by tick@…

  • Owner changed from jserv@… to tick@…

I will add a function "cancel_atcmd " in gsmd to let AP has chance to cancel a
busy command (long command)

And, I may change it from the patch 355.

comment:7 Changed 11 years ago by tick@…

  • Status changed from new to assigned

Changed 11 years ago by balrogg@…

Implement atcmd cancelling and VOICECALL_HANGUP

Changed 11 years ago by tick@…

cancel_atcmd

comment:8 Changed 11 years ago by tick@…

  • attachments.isobsolete changed from 0 to 1

comment:9 Changed 11 years ago by tick@…

  • Status changed from assigned to closed
  • Resolution set to fixed

I want to switch this issue to fixed.
If this issue has been proved solved, please switch it to solved.

Note: See TracTickets for help on using tickets.