Ticket #944 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

[lgsm_signal_qualities] The function name of the prototype in misc.h and libgsmd_network.c

Reported by: sudharsh@… Owned by: jserv@…
Priority: high Milestone:
Component: libgsmd Version: current svn head
Severity: normal Keywords:
Cc: buglog@… Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: PatchReviewResult:
Reproducible:

Description

Hi,
The name of the function to get the signal quality and the required arguments
are different in the prototypes and the definition.

include/misc.h: extern int lgsm_get_signal_quality(struct lgsm_handle *h,

unsigned int *rssi);

src/libgsmd_network.c: lgsm_signal_quality(struct lgsm_handle *lh)

Apologies if its known already.

Change History

comment:1 Changed 6 years ago by jserv@…

  • Owner changed from laforge@… to jserv@…

comment:2 Changed 6 years ago by jserv@…

  • Status changed from new to assigned

lgsm_signal_quality function with single parameter should make sense rather than
lgsm_get_signal_quality with two ones. The change was checked in svn. How do
you think?

comment:3 Changed 6 years ago by sudharsh@…

wow that was quick =),
i will check if it works and report back.

comment:4 Changed 6 years ago by tick@…

  • Status changed from assigned to closed
  • Resolution set to fixed

as message #1
I'd want to switch this to fixed

comment:5 Changed 6 years ago by sudharsh@…

Yup, signal quality works..Apologies for not reporting back..=)

Note: See TracTickets for help on using tickets.