Ticket #1095 (closed defect: fixed)

Opened 11 years ago

Last modified 20 months ago

Calculator isn't using LINGUAS

Reported by: milo_casagrande@… Owned by: buglog@…
Priority: high Milestone:
Component: openmoko-calculator Version: 2007.2
Severity: normal Keywords:
Cc: buglog@…, rodolphe.ortalo@… Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: PatchReviewResult:
Reproducible:

Description

The package calculator isn't using LINGUAS file in the po directory, it's still
using ALL_LINGUAS in the configure.ac file.

Attachments

linguas.diff (645 bytes) - added by milo_casagrande@… 11 years ago.
Patch for this bug
patch.diff (1.4 KB) - added by milo_casagrande@… 11 years ago.
Patch
patch.2.diff (1.4 KB) - added by milo_casagrande@… 11 years ago.
New patch

Change History

comment:1 Changed 11 years ago by rodolphe.ortalo@…

  • Status changed from new to assigned

comment:2 Changed 11 years ago by rodolphe.ortalo@…

  • Cc rodolphe.ortalo@… added

comment:3 Changed 11 years ago by rodolphe.ortalo@…

I tried to apply your patch but it lead to strange issues wrt dist and distcheck
targets (esp. in a recursive configure context) so I chose to revert it for the
moment.
Can you point me at accurate and recent documentation (or examples) on these
i18n issues (especially wrt to the differences between LINGUAS file and
ALL_LINGUAS configure.ac directive or intoolize vs glib-gettextize)?

comment:4 Changed 11 years ago by milo_casagrande@…

I checked within GNOME's documentation, in particular with the old LINGUAS goal
from GNOME: http://live.gnome.org/GnomeGoals/PoLinguas (it says to use
IT_PROG_INTLTOOL, but other openmoko applications use AC_PROG_INTLTOOL).

On GNU gettext docs there's not much about LINGUAS
(http://www.gnu.org/software/gettext/manual/html_node/gettext_10.html#po_002fLINGUAS)

Usually it's only needed to change the ALL_LINGUAS. I checked with other
openmoko applications that have the LINGUAS file and the configure set properly
(openmoko-browser and feedreader) and also with some GNOME applications.

Basically for translators it's easier to have the LINGUAS file inside the po/
directory, so they can work only in that directory and not need to touch the
configure.ac file.

I will check more deeply within other docs too.

Changed 11 years ago by milo_casagrande@…

Patch for this bug

comment:5 Changed 11 years ago by milo_casagrande@…

  • attachments.isobsolete changed from 0 to 1

Changed 11 years ago by milo_casagrande@…

Patch

comment:6 Changed 11 years ago by milo_casagrande@…

  • attachments.isobsolete changed from 0 to 1

comment:7 Changed 11 years ago by rodolphe.ortalo@…

Thanks for your attempts! I had already tried something pretty similar however
(not exactly: I copied openmoko-today2 which uses slightly different directives).
I'll try again to see if my distcheck works with this modif. (esp. when 543 is
taken into account).
NB: Your patch references the it translation. ;-)

comment:8 Changed 11 years ago by rodolphe.ortalo@…

Wow, I just found a good reference to my problem:
http://mail.gnome.org/archives/desktop-devel-list/2007-September/msg00156.html

It seems AC_CONFIG_AUX_DIR(.) should be useful in this configure.ac (but I guess
it should also in many other places...)

comment:9 Changed 11 years ago by milo_casagrande@…

Thanks for your attempts! I had already tried something pretty similar however
(not exactly: I copied openmoko-today2 which uses slightly different sirectives).

Oh, even for the autogen.sh? You're using gnome-autogen.sh so...

I'll try again to see if my distcheck works with this modif. (esp. when 543 is
taken into account).
NB: Your patch references the it translation. ;-)

Oops... forgot to strip it out... sorry...

Wow, I just found a good reference to my problem:
http://mail.gnome.org/archives/desktop-devel-list/2007-September/msg00156.html

Nice info!

It seems AC_CONFIG_AUX_DIR(.) should be useful in this configure.ac (but I guess
it should also in many other places...)

I was checking even at autoconf's doc. The doc says to use, at the end of the
configure.ac, first AC_CONFIG_FILES([list of files]) and then the macro
AC_OUTPUT. The AC_OUTPUT([list of files]) macro seems obsolete.

comment:10 Changed 11 years ago by rodolphe.ortalo@…

  • Status changed from assigned to closed
  • Resolution set to fixed

Integrated a variation of your patch (with adjustment to configure.ac) into
revison 3633.

comment:11 Changed 20 months ago by HaroNusy

My Secure Tabs Pharmacy http://cialtobuy.com - cialis Medicine From Mexico
Viagra Britain Rx Express Canada Drugs
Lioresal Intrathecal Effets Secondaires <a href=http://cialtobuy.com >cialis</a> Tadifil

Note: See TracTickets for help on using tickets.