Ticket #1163 (closed defect: fixed)

Opened 11 years ago

Last modified 11 years ago

cannot send SMS from Contacts

Reported by: erin_yueh@… Owned by: chris@…
Priority: high Milestone:
Component: openmoko-contacts Version: 2007.2
Severity: normal Keywords: VERIFIED
Cc: buglog@…, erin_yueh@… Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: PatchReviewResult:
Reproducible:

Description

http://wiki.openmoko.org/wiki/Contacts/2007.2
from our wiki, we can send a SMS from Contacts

Change History

comment:1 Changed 11 years ago by erin_yueh@…

  • Owner changed from thomas@… to chris@…

we can press the second tab to launch SMS editor and send a SMS to this contact
http://wiki.openmoko.org/images/5/57/Contacts-main-double-height.png

comment:2 Changed 11 years ago by chris@…

I'm not really sure what's the best way to go about this... Should I just add a
command-line parameter to openmoko-messages2 and call it from contacts, or
should we use dbus? Or something else? Comments appreciated.

comment:3 Changed 11 years ago by roman.moravcik@…

I'm working on something similar. There is no way to add contact
from dialer history. I'm missing this feature. I decided to use dbus
for this purpose. You can find my patches here:

http://www.w-ww.org/~rmoravcik/openmoko/dialer_add_contact_from_history.patch
http://www.w-ww.org/~rmoravcik/openmoko/contacts_add_contact_dbus.patch

And one screenshot:

http://www.w-ww.org/~rmoravcik/openmoko/dialer_history.png

Dialer patch include also some other changes (it remove brackets
from incoming clip, this should be done also in gsmd, disable toolbar
buttons, if nothing is selected...). I'm not expert for dbus stuff
and I don't know if it is integrated correctly to contacts application.

Any comments, suggestions?

comment:4 Changed 11 years ago by chris@…

First glance this looks good to me, I'll ask Thomas if he'll have a look, he'll
know the contacts/dialer stuff better than me I think. Only thing I can think of
is that you'll want to make the button insensitive if the contact exists already
(I think there's a convenience function in dialer to look up numbers already
(although it's a little broken at the mo, but I can fix that))

comment:5 Changed 11 years ago by thomas@…

Patches look good to me, although I don't think it solves the original bug report?

comment:6 Changed 11 years ago by roman.moravcik@…

No, that patches doesn't solve original bug report. It was something
like proposal, how should be solved this issue.

I think, similar dbus interface should be added to the openmoko-messages
and "send sms" button from dialer or contacts application could use that
interface.

comment:7 Changed 11 years ago by chris@…

DBus interface added to openmoko-messages2 in r3795, now working on contacts.

comment:8 Changed 11 years ago by chris@…

  • Status changed from new to closed
  • Resolution set to fixed

Bug fixed in r3796 of openmoko-messages2 and sms sending button implemented in
r397 of openmoko-contacts2.

comment:9 Changed 11 years ago by erin_yueh@…

yeah! well done! i can click sending SMS from contacts with latest version now. :)

comment:10 Changed 11 years ago by erin_yueh@…

oops, it's not working in my NEO again and i am using openmoko-contacts r397.
any idea why sometimes i press some button but there is no response?

comment:11 Changed 11 years ago by chris@…

The SMS button in Contacts or the send button in messages? I don't know why
there'd be no response without any more specific detail (console output?)

comment:12 Changed 11 years ago by erin_yueh@…

  • Keywords VERIFIED added

bug verified by daily build
OpenMoko?-openmoko-devel-image-glibc-ipk-P1-Snapshot-20080130-fic-gta02.rootfs.jffs2
version.

Note: See TracTickets for help on using tickets.