Ticket #1839 (closed defect: fixed)

Opened 11 years ago

Last modified 11 years ago

openmoko-dialer2 misses gsmloc data on outgoing calls

Reported by: LeRoutier Owned by: openmoko-devel
Priority: normal Milestone:
Component: unknown Version:
Severity: normal Keywords: HasPatch
Cc: Blocked By:
Blocking: Estimated Completion (week):
HasPatchForReview: PatchReviewResult:
Reproducible:

Description

in .moko/journal/journal.ics, I noticed all outgoing calls where missing GSM LAC & CID,

(Something like that :
X-OPENMOKO-ENTRY-GSM-LOCATION;X-LAC=900;X-CID=47880:dummy)

They were always at 0 and 0

I traced it to a missing call to moko_journal_entry_set_gsm_location

Attached patch adds this call on the right place and also explains a magic number found in the same function.

Attachments

openmoko_dialer__add_gsmlocdata+explain_magic_number.patch (1.7 KB) - added by LeRoutier 11 years ago.
Adds gsm loc data to outgoing calls in journal and explain a magic number

Change History

Changed 11 years ago by LeRoutier

Adds gsm loc data to outgoing calls in journal and explain a magic number

comment:1 Changed 11 years ago by zecke

  • Keywords HasPatch added

comment:2 Changed 11 years ago by erin

patch committed to revision 4611. Thank LeRoutier? for your contribution!

comment:3 Changed 11 years ago by erin_yueh

  • Status changed from new to closed
  • Resolution set to fixed

mark it to fixed.

Note: See TracTickets for help on using tickets.